feat(linter): impl only-export-components to react rules #14122

re-taro · 2025-09-25T15:41:33Z

Summary

close: #12386

I re-implemented only-export-components rule for react.

originals:

graphite-app · 2025-09-25T15:41:44Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull Request Overview

This PR implements the only-export-components rule for React linter rules, ensuring modules only export React components and HMR-safe items to support Fast Refresh functionality.

Adds comprehensive validation for React component exports and Fast Refresh compatibility
Implements configurable options for allowed export names, constant exports, custom HOCs, and JS file checking
Provides detailed diagnostics for various violation scenarios including anonymous components, mixed exports, and React contexts

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`crates/oxc_linter/src/rules/react/only_export_components.rs`	Complete implementation of the only-export-components rule with export analysis, component detection, and diagnostic reporting
`crates/oxc_linter/src/snapshots/react_only_export_components.snap`	Test snapshots showing expected diagnostic outputs for various rule violations
`crates/oxc_linter/src/rules.rs`	Module registration adding the new rule to the linter's rule set

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/only_export_components.rs

codspeed-hq · 2025-09-25T15:47:04Z

CodSpeed Performance Report

Merging #14122 will not alter performance

_{Comparing re-taro:feat/eslint-plugin-react-refresh (7f6cf81) with main (5db9774)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (b13c4bd) during the generation of this report, so 5db9774 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/react/only_export_components.rs

re-taro · 2025-09-27T07:24:01Z

@camc314

We've addressed the feedback you provided!

crates/oxc_linter/src/rules/react/only_export_components.rs

camc314

Thank you!

gleb-krotov-veeam · 2025-10-13T11:43:20Z

How can I use it? Is this rule turn on automatically if I used Oxc's React Plugin?

camc314 · 2025-10-13T12:16:29Z

How can I use it? Is this rule turn on automatically if I used Oxc's React Plugin?

@gleb-krotov-veeam

This rule isn't enabled by default. you'll need to add react to your plugins array, as well as adding react/only-export-components to your rules object.

{
    "plugins": ["react"],
    "rules': {
        "react/only-export-components": "error"
    }
}

Also, please note that this hasn't been released yet (release planned for tomorrow)

## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

re-taro requested a review from camc314 as a code owner September 25, 2025 15:41

Copilot AI review requested due to automatic review settings September 25, 2025 15:41

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Sep 25, 2025

Copilot AI reviewed Sep 25, 2025

View reviewed changes

graphite-app bot reviewed Sep 25, 2025

View reviewed changes